Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Snowman/Iron Golem Spawn Eggs conditionally #509

Closed
wants to merge 3 commits into from
Closed

Add Snowman/Iron Golem Spawn Eggs conditionally #509

wants to merge 3 commits into from

Conversation

glowredman
Copy link
Member

Depends on and adds compat to GTNewHorizons/Hodgepodge#398

@glowredman glowredman requested a review from a team July 30, 2024 20:29
@glowredman
Add min HP version
f2d6b52 
NOTE: FML only considers this restriction if HP is present, this doesn't turn HP into a hard-dep!
mitchej123
mitchej123 requested changes Aug 8, 2024
View reviewed changes
Copy link

@mitchej123 mitchej123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't add a dep for a specific hodgepodge version, handle old ones gracefully

@mitchej123 mitchej123 mentioned this pull request Aug 9, 2024
Closed
mitchej123
mitchej123 approved these changes Aug 10, 2024
View reviewed changes
Copy link

@mitchej123 mitchej123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine once the pre release dep is gone

@Dream-Master
Copy link
Member

@mitchej123 can you approve the hodgepodge pr as well ?

@glowredman
Copy link
Member Author

Replaced by GTNewHorizons/Hodgepodge@6923bb3#diff-6d6ea392b5f8c6d98cbf5ca099fc56393c71b870222991be4b6b95edcb4a710fR102-R105

@glowredman glowredman closed this Aug 11, 2024
@glowredman glowredman deleted the eggs branch August 11, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitchej123 mitchej123 mitchej123 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@glowredman @Dream-Master @mitchej123