Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizable stat leaderboards #113

Merged
merged 7 commits into from
Sep 13, 2024
Merged

Customizable stat leaderboards #113

merged 7 commits into from
Sep 13, 2024

Conversation

Lyfts
Copy link
Member

@Lyfts Lyfts commented Sep 7, 2024

Makes it possible for server owners to easily add leaderboards for any registered stat, so if you ever wanted a leaderboard for most iron shovels broken, distance traveled by minecart, amount of fish caught etc. you can now :) (this also includes stats registered by other mods)

Moves all of the existing stat leaderboards (any leaderboard that only needs a minecraft stat to function) to the new leaderboards.json file in the /serverutilities/server folder.
It's super easy to add new ones as you only really need to copy one of the existing ones and switch the stat id to the one you want, the name of the leaderboard as well as the ordering of the entries in the leaderboard can also be changed in the file if desired.
A full list of registered stat id's along with as good a description as we can get can be dumped to txt file using /dump_stats.

Also stops piggybacking of our own event to register the leaderboards. The event continues to exist for other mods to use.

Closes #111

@Lyfts Lyfts requested a review from a team September 7, 2024 19:53
Copy link
Contributor

github-actions bot commented Sep 9, 2024

Warning: 2 uncommitted changes
#115

Co-authored-by: GitHub GTNH Actions <>
Copy link
Contributor

@Ethryan Ethryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Dream-Master Dream-Master merged commit 6aa640b into master Sep 13, 2024
1 check passed
@Dream-Master Dream-Master deleted the custom-leaderboards branch September 13, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: Leaderboards with options to add and remove statistics.
3 participants