Replace command override with mixins #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lyfts <127234178+Lyfts@users.noreply.github.com>
Signed-off-by: Lyfts <127234178+Lyfts@users.noreply.github.com>
Signed-off-by: Lyfts <127234178+Lyfts@users.noreply.github.com>
Signed-off-by: Lyfts <127234178+Lyfts@users.noreply.github.com>
Ethryan
approved these changes
Oct 22, 2024
… mc classes too early (it wasn't used anyways) Signed-off-by: Lyfts <127234178+Lyfts@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the incredibly janky command override system with 2 very simple mixins, this allows command permissions to function like any other permission would rather than being their own separate system.
It should in theory also fix the bukkit incompatibility that command override had, whether the command permissions will work for bukkit servers has not been tested yet but it shouldn't cause them to crash anymore.
Using mixins will also enable us to fix a few previously impossible/cumbersome issues such as
#64
#102
#105 (this one could also be done by overriding the command but that's not a great solution)
None of those potential fixes are included in this pr though.