Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potential crash when adding player to rank #144

Merged
merged 1 commit into from
Dec 7, 2024

Conversation

Lyfts
Copy link
Member

@Lyfts Lyfts commented Dec 6, 2024

When a serialized collection only has a single element DataIn.readCollection() will return an immutable collection, which is of course not desired here.

Closes #143

Signed-off-by: Lyfts <127234178+Lyfts@users.noreply.github.com>
@Lyfts Lyfts requested a review from a team December 6, 2024 21:33
@boubou19 boubou19 merged commit 126dc99 into master Dec 7, 2024
1 check passed
@boubou19 boubou19 deleted the fix-rank-add-crash branch December 7, 2024 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Client Crash when adding Rank to Player.
3 participants