Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix display names not syncing when player logs in #148

Merged
merged 3 commits into from
Dec 7, 2024

Conversation

Lyfts
Copy link
Member

@Lyfts Lyfts commented Dec 7, 2024

I forgot to send the display name of all the currently online players to the player that's joining the server 🤦

Closes #145

Lyfts added 2 commits December 7, 2024 10:50
Signed-off-by: Lyfts <127234178+Lyfts@users.noreply.github.com>
Signed-off-by: Lyfts <127234178+Lyfts@users.noreply.github.com>
@Lyfts Lyfts requested a review from a team December 7, 2024 09:59
@StoneLegion
Copy link

I went ahead and grabbed the build and can confirm with my alt that both the names are correctly syncing up now no matter who logins in after each other, etc. Thank you.

@boubou19 boubou19 enabled auto-merge (squash) December 7, 2024 19:55
@boubou19 boubou19 merged commit ff219c8 into master Dec 7, 2024
1 check passed
@boubou19 boubou19 deleted the fix-display-name-sync branch December 7, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tab List Names not correctly syncing Colors Up.
3 participants