Fix a few command issues #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lyfts <127234178+Lyfts@users.noreply.github.com>
Ethryan
approved these changes
Dec 10, 2024
Dream-Master
pushed a commit
that referenced
this pull request
Dec 10, 2024
Signed-off-by: Lyfts <127234178+Lyfts@users.noreply.github.com> (cherry picked from commit 3780a4a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blood magic overrides the lang key for the default
/helpcommands usage with its own https://github.com/GTNewHorizons/BloodMagic/blob/2e95450cf0601c30e82126614d86b59ad02f09f0/src/main/resources/assets/alchemicalwizardry/lang/en_US.lang#L349. I can't imagine that it's actually intended but to fix it I've just hardcoded the help subcommand to be/insert_parent_command helpwhich will also prevent any future issues.Closes GTNewHorizons/GT-New-Horizons-Modpack#18323
The
ConfigGroupclass that the rank config ui uses only support periods and underscores as special characters in the name which caused some botania commands (/botania-open&/botania-share) to be saved with incorrect permission nodes. This is fixed by simply replacing any special character that is not a period or underscore in the command permissions with an underscore.Closes GTNewHorizons/GT-New-Horizons-Modpack#18322