Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the new interface in AE2 for network bytes information. #52

Merged
merged 2 commits into from
Nov 20, 2023

Conversation

MCTBL
Copy link
Member

@MCTBL MCTBL commented Nov 19, 2023

No description provided.

@Dream-Master Dream-Master requested a review from a team November 19, 2023 19:49
@Alastors Alastors dismissed their stale review November 19, 2023 20:35

Outdated

@Cardinalstars
Copy link

Is this change in the wake of something changed in base AE2? If so a link would be helpful.

@MCTBL
Copy link
Member Author

MCTBL commented Nov 20, 2023

Is this change in the wake of something changed in base AE2? If so a link would be helpful.

GTNewHorizons/Applied-Energistics-2-Unofficial#419
I'm trying to add a byte information for ae network.

@Dream-Master Dream-Master requested review from Alastors and a team November 20, 2023 16:27
@Alastors
Copy link

Alastors commented Nov 20, 2023

I don't know enough about the AE2 codebase to knowingly review this in good conscious past things such as the commented out code from earlier.

@MCTBL
Copy link
Member Author

MCTBL commented Nov 20, 2023

I don't know enough about the AE2 codebase to knowingly review this in good conscious past things such as the commented out code from earlier.

I have not changed the totalTypes type, it still a int variable. I just change the method return type from int to long. And method getUsedTypes as the same.

@Dream-Master Dream-Master merged commit 92b2b36 into GTNewHorizons:master Nov 20, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants