Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wirelesshub #24

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Conversation

lordIcocain
Copy link

@lordIcocain lordIcocain commented Nov 11, 2024

Hub -> Hub = NO
Wireless -> Hub = OK
Wireless <- Hub = Wireless -> Hub
Not use power, should require Neutronium cell in recipe. (i can change)
Pick up only with wrench. idk how set meta when break. no color pick up.
Looks same as Wireless.

Closes GTNewHorizons/GT-New-Horizons-Modpack#14729

upd.
Added custom texture and color pickup.
Added power usage, sum power usage of connected wireless.
Added recipe.

image
image
image
image

@chochem chochem added the ongoing freeze - do not merge PR tagged with this do not meet the requirement to be merged during a freeze. label Nov 16, 2024
Copy link

@Glease Glease left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. drop with color configured thing: you are now using item meta 17 for the hub. just like the non-hub code that already exists here, you can use meta 17~34 for the hub (with 17 as colorless). e..g use stack.setItemDamage(te.color ==AEColor.Transparent ? 17 : 17 + te.color.ordinal() + 1) in getDrops() and then set the color like the existing code in onBlockPlacedBy()
  2. I'd very much prefer to have different texture for hubs. I've sent a request in #texture-dev, but if they are too occupied with other matter, using same texture is also acceptable for now

@lordIcocain lordIcocain requested a review from Glease December 6, 2024 13:08
@Glease
Copy link

Glease commented Dec 8, 2024

some work from our artists

since this is Hub, then it would be wireless connectir with H

Untitled_12-05-2024_01-45-20
top_on

Or we can make the hub white instead of black, or with "gold" tilt

Untitled_12-05-2024_01-45-20_3
Untitled_12-05-2024_01-45-20_5

what if it had like "clusters"?

image
Untitled_12-05-2024_01-45-20_6
image
Untitled_12-05-2024_01-45-20_6-1

@Dream-Master Dream-Master removed the ongoing freeze - do not merge PR tagged with this do not meet the requirement to be merged during a freeze. label Dec 8, 2024
@Dream-Master Dream-Master requested a review from a team December 8, 2024 18:03
@lordIcocain
Copy link
Author

I like H variant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "one to many" AE2 wireless connector.
4 participants