Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ghost TE creation on breaking wireless in survival mode. #26

Merged

Conversation

lordIcocain
Copy link

@lordIcocain lordIcocain commented Dec 7, 2024

When getDrops() called TE already non exist, so getTE() is create new one.
Wrench pick up not affected.

Before:

image

After:

image

@lordIcocain lordIcocain changed the title Fix ghost TE creation on breaking in survival mode. Fix ghost TE creation on breaking wireless in survival mode. Dec 7, 2024
Copy link

@RecursivePineapple RecursivePineapple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I don't know if it should be merged this close to stable, but I'll approve it for now.

@boubou19
Copy link
Member

boubou19 commented Dec 7, 2024

this will go in 2.7.1 to get proper testing

@boubou19 boubou19 added the ongoing freeze - do not merge PR tagged with this do not meet the requirement to be merged during a freeze. label Dec 7, 2024
@Dream-Master Dream-Master removed the ongoing freeze - do not merge PR tagged with this do not meet the requirement to be merged during a freeze. label Dec 8, 2024
@Dream-Master Dream-Master requested a review from a team December 8, 2024 18:03
@serenibyss serenibyss merged commit e0038ce into GTNewHorizons:master Dec 18, 2024
1 check passed
@lordIcocain lordIcocain deleted the fix-ghost-te-on-survival-break branch December 18, 2024 18:38
Dream-Master pushed a commit that referenced this pull request Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants