fix cast of vectypes with sizeof < vec4f (16) #1457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Это замедлит код. Надо хотя бы оптимизировать загрузку всех типов меньше 12 байт. |
No, it won't. |
|
How? v_ldu forces loading garbage from stack to unused components, your version forces zeroing. |
Well, stack part is optional. Compiler might not use stack at all. And using v_ldu() on vec3 cause it to miscompile stuff. See downstream commit for additional details |
Do use memcpy-to-temp-var on clang cast as it's portable, correct and fast and use various type of loads for other compilers (msvc/gcc) to match generated code on clang This fixes clang18 binding of inline functions that return vec3/Point3 and removes special code path for TSAN.
virt00l
force-pushed
the
fix-vectypes-cast
branch
from
c2c4ccf to
e413593
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do use memcpy-to-temp-var cast as it's portable, correct and fast
This fixes clang18 binding of inline functions that return vec3/Point3 and return special code path for TSAN.