fix: update apport coredump path handling for CorefileFinder #2518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! Do you have a link to the source or docs you used? Please add it to the code too so we can monitor for future changes if this wasn't the default behavior before. |
|
@peace-maker, I updated the comments. I've made the changes in the dev branch. Is that fine, or should I use the stable one? |
|
The stable branch is would be better indeed. Thank you for the references, looks good! |
Meetesh-Saini
force-pushed
the
apport-corefile
branch
from
e1d97c0 to
b742810
Compare
peace-maker
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apport uses the executable's pathname in the core filename. This update modifies the implementation to use the absolute path of the executable and replace both
/and.with_in the pathname to match apport's implementation.Reference source:
https://github.com/canonical/apport/blob/4bbb179b8f92989bf7c1ee3692074f35d70ef3e8/data/apport#L110
https://github.com/canonical/apport/blob/4bbb179b8f92989bf7c1ee3692074f35d70ef3e8/apport/fileutils.py#L599
Apport calls
get_core_pathwithoptions.executable_path, which corresponds to the executable's pathname, as specified by the%Eplaceholder in the core pattern (seeman coreandapport --help).