favor ArchAddrWidth over RegAddrWidth (ArchReg ...)
#356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanGlScott
approved these changes
Dec 9, 2023
Ptival
force-pushed
the
vr/archaddrwidth
branch
from
51a6d16
to
ceec54d
Compare
RyanGlScott
reviewed
Dec 11, 2023
Ptival
force-pushed
the
vr/archaddrwidth
branch
from
ceec54d
to
416fb2d
Compare
Ptival
force-pushed
the
vr/archaddrwidth
branch
from
416fb2d
to
d2f7028
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a suggestion, but we're frequently using
RegAddrWidth (ArchReg arch)when we also have a type synonym for exactly this, namelyArchAddrWidth arch.I feel like I almost never need to dig into the details of it, so I'd personally prefer only ever seeing
ArchAddrWidth, but I'm open to this suggestion being rejected for reasons I'm not aware of.