Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: chat components, fix user info form bug #427

Merged
merged 4 commits into from
Dec 20, 2024
Merged

Conversation

JohnsonMao
Copy link
Contributor

Why need this change? / Root cause:

  • Improved maintainability and reusability of shared chat components.
  • Fixed a data flow issue in the user info form that caused unexpected behavior.
  • Added internationalization (i18n) to support multiple languages in the project.
  • Added Dependabot configuration to automate dependency management and ensure security updates.

Changes made:

  • Unified the chat component structure by consolidating /chat/v2 into /chat
  • Resolved the user info form data flow bug by adjusting the state update logic

Test Scope / Change impact:

  • Verified that refactored chat components function correctly across all relevant pages.
  • Tested the user info form to ensure the bug is resolved and the data flow is accurate.
  • Checked that i18n integration works as expected in supported languages.

Issue

  • none

@JohnsonMao JohnsonMao self-assigned this Dec 19, 2024
@github-actions github-actions bot added bug Fix something in main refactor refactor the changes already merged. labels Dec 19, 2024
@GaaSBot
Copy link

GaaSBot commented Dec 19, 2024

Knip Scan Result for de6395b

Unused files (8)
Unused files (8)
.bundlewatch.config.js
components/shared/Footer.tsx
configs/i18nConfigs.ts
lighthouserc.js
reset.d.ts
scripts/iconConverter/IconTemplate.tsx
scripts/knipScanReporter.js
scripts/lhciScanReporter.js
Unused dependencies (2)
Unused dependencies (2)
@svgr/webpack package.json
sharp package.json
Unused devDependencies (5)
Unused devDependencies (5)
@actions/github package.json
@octokit/core package.json
@storybook/blocks package.json
@storybook/testing-library package.json
@total-typescript/ts-reset package.json
Unused exports (2)
Unused exports (2)
createMockFriendMessages components/shared/Chat/mocks/mock.tsx
playerCancelReady requests/rooms/index.ts
Unused exports in namespaces (1)
Unused exports in namespaces (1)
BreadcrumbItem components/shared/Breadcrumb/Breadcrumb.tsx
Unused exported types (2)
Unused exported types (2)
ChatHeaderProps type components/shared/Chat/ChatHeader.tsx
RoomEntryError type requests/rooms/index.ts
Unused exported types in namespaces (2)
Unused exported types in namespaces (2)
BaseBoxFancyProp interface components/shared/BoxFancy/BoxFancy.tsx
BreadcrumbItemProps interface components/shared/Breadcrumb/Breadcrumb.tsx
Unused exported enum members (1)
Unused exported enum members (1)
PRIMARY_TRANSPARENT ButtonVariant components/shared/Button/v2/Button.tsx
Configuration issues (1)
Configuration issues (1)
Unused item in ignoreDependencies: @next/bundle-analyzer

@GaaSBot
Copy link

GaaSBot commented Dec 19, 2024

🤖 Lighthouse Scan Result for de6395b

/rooms
Metric Value
Performance 76
Seo 90
Accessibility 84
HTML Report for LHCI Scan Report Link
/rooms/abc
Metric Value
Performance 76
Seo 90
Accessibility 84
HTML Report for LHCI Scan Report Link
/login
Metric Value
Performance 69
Seo 90
Accessibility 97
HTML Report for LHCI Scan Report Link

@JohnsonMao JohnsonMao merged commit 1a74129 into main Dec 20, 2024
9 checks passed
@JohnsonMao JohnsonMao deleted the refactor/room branch December 20, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fix something in main refactor refactor the changes already merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants