DeltaRem and RandomizeButton BugFixes (#111)

GamesCrafters · Feb 20, 2024 · f3f979c · f3f979c
1 parent f28aac6
commit f3f979c
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 10 deletions.
diff --git a/package.json b/package.json
@@ -48,5 +48,5 @@
  "preview:https": "serve dist",
  "reinstall": "rm -rf node_modules; yarn; vue-tsc --noEmit"
  },
- "version": "5.0.0-alpha.283"
+ "version": "5.0.0-alpha.284"
 }
diff --git a/src/components/units/VVH/AppGameVvhBody.vue b/src/components/units/VVH/AppGameVvhBody.vue
@@ -172,15 +172,15 @@
  :y="gridTop + roundNumber * rowHeight - rowHeight / 2"
  dominant-baseline="middle"
  text-anchor="middle">
- {{ currentValuedRounds[roundNumber].move.substring(0,4) === 'zzzz' ? '' : currentValuedRounds[roundNumber].move }}
+ {{ currentValuedRounds[roundNumber].move[0] == '~' ? '' : currentValuedRounds[roundNumber].move }}
  </text>
  <text class="move-coordinate"
  v-else
  :x="gridRight + yCoordinateWidth / 2"
  :y="gridTop + roundNumber * rowHeight - rowHeight / 2"
  dominant-baseline="middle"
  text-anchor="middle">
- {{ currentValuedRounds[roundNumber].move.substring(0,4) === 'zzzz' ? '' : currentValuedRounds[roundNumber].move }}
+ {{ currentValuedRounds[roundNumber].move[0] == '~' ? '' : currentValuedRounds[roundNumber].move }}
  </text>
  </template>
 

diff --git a/src/models/images/sfxoff.svg b/src/models/images/sfxoff.svg
diff --git a/src/scripts/gamesmanUni/index.ts b/src/scripts/gamesmanUni/index.ts
@@ -115,7 +115,7 @@ export const initiateMatch = async (app: Types.App, payload: {
  const variant = await loadVariant(app, payload);
  game.variants[payload.variantId] = variant;
 
- const startPosition = payload.startPosition ? payload.startPosition : variant.startPosition;
+ const startPosition = (payload.startPosition && payload.startPosition !== 'random') ? payload.startPosition : variant.startPosition;
 
  const updatedApp = await loadPosition(app, { ...payload, position: startPosition });
  if (!updatedApp) return undefined;
@@ -145,7 +145,10 @@ export const initiateMatch = async (app: Types.App, payload: {
  deepcopy(app.currentMatch.round)
  ];
  playGameAmbience();
- await addInstructions(app, payload);
+
+ if (payload.startPosition !== 'random') {
+ await addInstructions(app, payload);
+ }
  return app;
 };
 
@@ -181,7 +184,9 @@ const calculateMoveButtonOpacities = (moves: Array<GCTAPITypes.Move>) => {
  formattedMoves[moves[0].move] = { ...moves[0], moveValueOpacity: 1 };
  }
  for (let i = 1; i < moves.length; i++) {
- formattedMoves[moves[i].move] = { ...moves[i], moveValueOpacity: 1 };
+ if (!(moves[i].move in formattedMoves)) {
+ formattedMoves[moves[i].move] = { ...moves[i], moveValueOpacity: 1 };
+ }
  const previousMove = formattedMoves[moves[i - 1].move];
  const currentMove = formattedMoves[moves[i].move];
  if ((previousMove.moveValue === currentMove.moveValue) || (previousMove.moveValue === 'tie' && currentMove.moveValue === 'draw')) {