Allow set of prometheus collector addr as env var #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agershman
force-pushed
the
collector-addr-env-var
branch
from
f5eddcb
to
e62e712
Compare
agershman
commented
Dec 15, 2023
agershman
force-pushed
the
collector-addr-env-var
branch
from
e62e712
to
6f7014d
Compare
Themimitoof
approved these changes
Dec 20, 2023
gdchamal
approved these changes
Dec 20, 2023
|
I've release 1.1.0 of celery-prometheus at the moment. I've added a commit to get it working with celery 5. 5f7f233 I guess click already handle env vars for that but I've never use click elsewhere and did not read its docs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking to allow setting of the prometheus collector address string as an environment variable. This is useful in certain contexts where configuration is more environment variable driven than command and argument driven.