Skip to content

Commit

Permalink
sigAbort during begin transaction fails
Browse files Browse the repository at this point in the history
Need to make sure handling the sig abort runs the handler blocks and tells the user of the failure.
  • Loading branch information
Eric Winger authored and Eric Winger committed Nov 2, 2021
1 parent 795ef18 commit 191a6e4
Showing 1 changed file with 8 additions and 5 deletions.
13 changes: 8 additions & 5 deletions sources/Rowan UI Base.pax
Original file line number Diff line number Diff line change
Expand Up @@ -1097,7 +1097,7 @@ You must abort your transaction before retrying the operation.
Would you like to abort now?')
ifTrue: [JadePresenter abortTransactionInSession: self]]]
ensure: [self enableSignaledAbortError "must reenable each time a sig abort error is received"].
error abort "Shutdown this process. An abort happened or needs to happen"!
Processor activeProcess terminate "this should run exception handlers" !

hasServer

Expand Down Expand Up @@ -2159,10 +2159,13 @@ autoCommitExecutionString

basicBeginTransaction
| answeringService |
answeringService := RowanAnsweringService new.
answeringService exec: 'System beginTransaction' session: gciSession.
self setInTransaction: answeringService session: gciSession.
JadePresenter trigger: #abortedTransaction!

[answeringService := RowanAnsweringService new.
answeringService exec: 'System beginTransaction' session: gciSession]
ensure:
[self setInTransaction: answeringService session: gciSession.
JadePresenter trigger: #abortedTransaction.
self inTransaction ifFalse: [MessageBox notify: 'Begin transaction failed. Please try again.']]!

basicCloneProject: path root: root
| service |
Expand Down

0 comments on commit 191a6e4

Please sign in to comment.