gmtlogo: Create the gmt_letters array dynamically to avoid MSVC compiler error #8629
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported in conda-forge/gmt-feedstock#302 (comment), building GMT source code with MSVC started to fail with following errors:
I believe it's caused by behavior changes of new MSVC versions. In PR #8627 and #8628, we tried to improve the handling of
NAN
on Windows to avoid the error, but it seems we don't have a good solution there.Instead, we can refactor the
gmt_letters
array ingmtlogo.c
to avoid initializinggmt_letters
withNAN
. This is done by splitting thegmt_letters
array into three separate arrays (for the letter G, M and T, respectively), and then creating thegmt_letters
array by joining the three arrays withNAN
records. This PR also reverts the changes in PR #8627Now the build passes.