-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: specify required fields in open api specs #173
Conversation
Reviewer's Guide by SourceryThis PR updates the OpenAPI specification by refining required fields and schema references. The changes primarily focus on cleaning up the schema definitions by explicitly marking required fields and removing optional ones from the required list. It also extracts the query operator enum into a separate reusable schema component. ER Diagram for Updated OpenAPI SpecificationerDiagram
DatasetSearchQueryFacet {
ARRAY entries
STRING source
STRING type
STRING key
STRING label
}
DatasetSearchQueryFacet ||--o{ QueryEntry : contains
QueryEntry {
STRING key
STRING value
}
QueryOperator {
STRING operator
}
DatasetSearchQueryFacet ||--o{ QueryOperator : uses
DatasetsSearchResponse {
STRING id
STRING title
STRING description
}
RetrievedDistribution {
STRING id
STRING title
STRING description
}
ValueLabel {
STRING value
STRING label
}
ErrorResponse {
STRING title
STRING status
STRING detail
}
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @admy7 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
e984241
to
91edde6
Compare
No description provided.