Split sanitize and normalize to be separate operations #4267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janette
force-pushed
the
split-normalize-and-sanitize
branch
from
f8d4c7e to
658bde6
Compare
janette
changed the title
|
@janette is the issue that the branch this is targeting is 'update-addDateExpressions' instead of '2.x'? |
|
Your also might need to rebase this branch of 2.x |
dmundra
reviewed
Oct 14, 2024
| return $property; | ||
| } | ||
|
|
||
| private function sanitizeProperty(object $property) { |
There was a problem hiding this comment.
@janette I think splitting this function potentially causing the $alias error but I am not sure. It is one place to debug.
janette
force-pushed
the
split-normalize-and-sanitize
branch
from
658bde6 to
06d493a
Compare
janette
requested review from
dafeder and
dmundra
and removed request for
dmundra
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
21640
WIP: Fixes applying date formats when using data dictionaries and the streamed CSV download API
Describe your changes
We only want to sanitize expressions, not when adding fields to the query.
QA Steps
Checklist before requesting review
If any of these are left unchecked, please provide an explanation