Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Drush command to apply a dictionary to a resource #4320

Open
wants to merge 5 commits into
base: 2.x
Choose a base branch
from

Conversation

paul-m
Copy link
Contributor

@paul-m paul-m commented Oct 21, 2024

Fixes [issue#]

Describe your changes

Adds a drush command: dkan:datastore:apply-dictionary

This command applies the data dictionary to the specified dataset, as configured in the site, and as specified by describedBy.

QA Steps

  • Set the site to not use data dictionaries.
  • Add a data dictionary to a dataset.
  • Set the site to use the data dictionary.
  • Run drush dkan:datastore:apply-dictionary for the dataset.
  • Verify that the data dictionary is displayed for the dataset.
  • If indexing was specified in the dictionary, verify that the indexing was applied to the database table for the resource.

Checklist before requesting review

If any of these are left unchecked, please provide an explanation

  • I have updated or added tests to cover my code
  • I have updated or added documentation

@paul-m
Copy link
Contributor Author

paul-m commented Dec 5, 2024

This is postponed until we get more clarity on how data dictionaries will operate in terms of type enforcing, indexing, and key definitions.

@paul-m paul-m marked this pull request as ready for review December 10, 2024 16:56
@paul-m
Copy link
Contributor Author

paul-m commented Dec 11, 2024

Marked as ready for review because we decided to go forward with this regardless of scope on data dictionaries.

@dafeder dafeder self-requested a review December 11, 2024 21:43
@dafeder dafeder self-assigned this Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants