4336: Return 400 error on invalid JSON sent to the datastore API #4341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul-m
requested changes
Nov 15, 2024
| @@ -221,6 +221,9 @@ protected function extractMetastoreDependencies(DatastoreQuery $datastoreQuery): | |||
| protected function buildDatastoreQuery(Request $request, mixed $identifier = NULL) { | |||
There was a problem hiding this comment.
\Drupal\datastore\Controller\QueryDownloadController::buildDatastoreQuery() overrides this... Both call getPayloadJson() which is probably where we should throw the exception.
So: Move this checking to either getPayloadJson() or fixTypes(), and add a bad JSON test for both query controller and download query controller.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4336
Describe your changes
Better response for invalid JSON
QA Steps
Checklist before requesting review
If any of these are left unchecked, please provide an explanation