Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make response stream max age a configuration #4348

Open
wants to merge 11 commits into
base: 2.x
Choose a base branch
from
Open

Conversation

zedmonds96
Copy link

@zedmonds96 zedmonds96 commented Nov 26, 2024

Fixes see 21638

Describe your changes

  • Added datastore_response_stream_max_age to datastore.settings.yml with a default of 3600 seconds.
  • Updated DatastoreSettingsForm to include a configurable field for response stream max-age.
  • Modified QueryDownloadController to use the configured response_stream_max_age instead of a hardcoded value.

QA Steps

  • Access the Datastore Settings form.
  • Modify the Response Stream Max-Age value and save the form.
  • Confirm that the new value is saved in the configuration
  • If no configuration is set, ensure the default 3600 seconds is applied.

Checklist before requesting review

If any of these are left unchecked, please provide an explanation

  • I have updated or added tests to cover my code
  • I have updated or added documentation

@janette janette changed the title WCMS-21638 make response steam max age a configuration Make response steam max age a configuration Dec 2, 2024
@janette janette changed the title Make response steam max age a configuration Make response stream max age a configuration Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant