Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BugFix - Add to Data Source parameters getting removed #3186

Merged
merged 3 commits into from
Aug 16, 2023
Merged

BugFix - Add to Data Source parameters getting removed #3186

merged 3 commits into from
Aug 16, 2023

Conversation

IamRanjeetSingh
Copy link
Contributor

Thank you for your contribution.
Before submitting this PR, please make sure:

  • PR description and commit message should describe the changes done in this PR
  • Verify the PR is pointing to correct branch i.e. Release or Beta branch if the code fix is for specific release , else point it to master
  • Latest Code from master or specific release branch is merged to your branch
  • No unwanted\commented\junk code is included
  • No new warning upon build solution
  • Code Summary\Comments are added to my code which explains what my code is doing
  • Existing unit test cases are passed
  • New Unit tests are added for your development
  • Sanity Tests are successfully executed for New and Existing Functionality
  • Verify that changes are compatible with all relevant browsers and platforms.
  • After creating pull request there should not be any conflicts
  • Resolve codacy comments
  • Builds and checks are passed before PR is sent for review
  • Resolve code review comments
  • Help Libray document is updated accordingly for Feature changes.

IamRanjeetSingh and others added 3 commits August 16, 2023 18:31
@IamRanjeetSingh
Description: Params from 'Add to Datasource' section were getting rem…
2e28940 
…oved.

RC:
1. Due to xaml level control event binding, events were getting triggered when binding the objects.
2. When clearing bindings for certain controls (e.g. xAddOutToDSCheckbox) events were getting triggered.
Fix:
1. Removed xaml level control event binding, added it from code-behind.
2. Removed the control's event handlers before clearing the bindings.
@IamRanjeetSingh
Merge branch 'Releases/Beta' into BugFix/AddToDSParamsGettingRemoved
f37fecc
@IamRanjeetSingh
Merge branch 'Releases/Beta' into BugFix/AddToDSParamsGettingRemoved
cd7f8a2
@Maheshkale447 Maheshkale447 merged commit 68bdf00 into Releases/Beta Aug 16, 2023
5 of 8 checks passed
@Maheshkale447 Maheshkale447 deleted the BugFix/AddToDSParamsGettingRemoved branch August 16, 2023 13:36
@IamRanjeetSingh IamRanjeetSingh restored the BugFix/AddToDSParamsGettingRemoved branch August 16, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IamRanjeetSingh @Maheshkale447