Changed the Environment Reference #3198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt in ValueExpressionEditorPage
Maheshkale447
requested changes
Sep 5, 2023
| @@ -941,16 +942,26 @@ private void xTestButton_Click(object sender, RoutedEventArgs e) | |||
| { | |||
| if (mVE == null) | |||
| { | |||
| if (mContext.Environment == null && mEnvs != null && mEnvs.Count > 0) | |||
| if (mContext.Environment == null && mEnvs != null && mEnvs.Count > 0 && WorkSpace.Instance.UserProfile.RecentEnvironment != Guid.Empty) | |||
There was a problem hiding this comment.
Please keep old condition as is in case WorkSpace.Instance.UserProfile.RecentEnvironment is empty or null or if GetCurrentEnvironment() returns null
There was a problem hiding this comment.
Implemented the requested change
There was a problem hiding this comment.
add else part to this if which will return first environment in case WorkSpace.Instance.UserProfile.RecentEnvironment is empty or null
There was a problem hiding this comment.
I have added the requested changes
added 6 commits
September 5, 2023 16:51
Maheshkale447
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the Environment Reference from the first in the environment variables list to the currently selected Environment.
This change was made for clients to use Environment Variables in Page Object Model. Now clients can use variables of the currently selected environment.
Thank you for your contribution.
Before submitting this PR, please make sure: