Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R&D - New Repository Serializer #3543

Open
wants to merge 25 commits into
base: master
Choose a base branch
from

merged master

1499fb4
Select commit
Loading
Failed to load commit list.
Open

R&D - New Repository Serializer #3543

merged master
1499fb4
Select commit
Loading
Failed to load commit list.
Codacy Production / Codacy Static Code Analysis required action Mar 7, 2024 in 0s

297 new issues (0 max.) of at least minor severity.

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 2
- Added 297
           

Complexity increasing per file
==============================
- Ginger/RepositorySerializerBenchmarks/Enhancements/ActivityIdentifiersXMLSerializer.cs  10
- Ginger/GingerCoreCommon/Repository/Serialization/BetterRepositorySerializer.cs  4
- Ginger/RepositorySerializerBenchmarks/Enhancements/RepositoryItemHeaderXMLSerializer.cs  9
- Ginger/GingerCoreCommon/Repository/Serialization/LiteXmlElement.cs  1
- Ginger/RepositorySerializerBenchmarks/Benchmarks/XmlParseBenchmark.cs  1
- Ginger/GingerCoreCommon/Repository/Serialization/Exceptions/MissingMandatoryNodeException.cs  1
- Ginger/RepositorySerializerBenchmarks/Benchmarks/Util/TestDataGenerator.cs  2
- Ginger/GingerCoreCommon/Repository/Serialization/SerializedSnapshot.cs  5
- Ginger/RepositorySerializerBenchmarks/Enhancements/LiteXML/LiteXMLAttribute.cs  1
- Ginger/GingerCoreCommon/Repository/Serialization/Exceptions/GingerSerializationException.cs  1
- Ginger/RepositorySerializerBenchmarks/Enhancements/ActivityXMLSerializer.cs  13
- Ginger/RepositorySerializerBenchmarks/Benchmarks/SerializationBenchmark.cs  2
- Ginger/RepositorySerializerBenchmarks/Enhancements/ActXMLSerializer.cs  11
- Ginger/GingerCoreCommon/Repository/Serialization/LiteXmlAttribute.cs  1
- Ginger/RepositorySerializerBenchmarks/Benchmarks/Util/TestActivitiesGenerator.cs  2
- Ginger/RepositorySerializerBenchmarks/Enhancements/BetterRepositorySerializerOld.cs  12
- Ginger/GingerCoreCommon/Repository/Serialization/Exceptions/UnexpectedXmlNodeException.cs  1
- Ginger/RepositorySerializerBenchmarks/Enhancements/DeserializePropertyInfo.cs  7
- Ginger/RepositorySerializerBenchmarks/Enhancements/ActInputValueXMLSerializer.cs  10
- Ginger/GingerCoreCommon/Repository/Serialization/XmlReaderExtensions.cs  6
- Ginger/GingerCoreCommon/Repository/Serialization/Exceptions/UnexpectedDeserializedPropertyType.cs  1
- Ginger/RepositorySerializerBenchmarks/Enhancements/VariableXMLSerializer.cs  10
- Ginger/RepositorySerializerBenchmarks/Benchmarks/DeserializationBenchmark.cs  2
- Ginger/GingerCoreCommon/Repository/Serialization/DeserializedSnapshot.cs  4
- Ginger/RepositorySerializerBenchmarks/Enhancements/LiteXML/LiteXMLElement.cs  9
- Ginger/GingerCoreCommon/Repository/RepositoryItemBaseFactory.cs  5
- Ginger/RepositorySerializerBenchmarks/Enhancements/RIBXmlReader.cs  7
- Ginger/RepositorySerializerBenchmarks/Enhancements/ActivitiesGroupXMLSerializer.cs  11
- Ginger/RepositorySerializerBenchmarks/Enhancements/BusinessFlowXMLSerializer.cs  15
- Ginger/GingerCoreCommon/Repository/Serialization/Exceptions/DeserializedPropertyNotFoundException.cs  1
- Ginger/RepositorySerializerBenchmarks/Enhancements/TargetApplicationXMLSerializer.cs  10
- Ginger/GingerCoreCommon/Actions/ActWithoutDriver.cs  1

See the complete overview on Codacy

Annotations

Check warning on line 1045 in Ginger/GingerCoreCommon/Repository/NewRepositorySerializer.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Ginger/GingerCoreCommon/Repository/NewRepositorySerializer.cs#L1045 

Remove this commented out code.

Check notice on line 11 in Ginger/GingerCoreCommon/Repository/Serialization/Exceptions/DeserializedPropertyNotFoundException.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Ginger/GingerCoreCommon/Repository/Serialization/Exceptions/DeserializedPropertyNotFoundException.cs#L11 

Remove this redundant 'base()' call.

Check warning on line 49 in Ginger/GingerCoreCommon/Repository/Serialization/XmlReaderExtensions.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Ginger/GingerCoreCommon/Repository/Serialization/XmlReaderExtensions.cs#L49 

Remove this commented out code.

Check failure on line 48 in Ginger/RepositorySerializerBenchmarks/Enhancements/ActInputValueXMLSerializer.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Ginger/RepositorySerializerBenchmarks/Enhancements/ActInputValueXMLSerializer.cs#L48 

Add curly braces around the nested statement(s) in this 'if' block.

Check failure on line 54 in Ginger/RepositorySerializerBenchmarks/Enhancements/ActInputValueXMLSerializer.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Ginger/RepositorySerializerBenchmarks/Enhancements/ActInputValueXMLSerializer.cs#L54 

Add curly braces around the nested statement(s) in this 'if' block.

Check failure on line 109 in Ginger/RepositorySerializerBenchmarks/Enhancements/ActXMLSerializer.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Ginger/RepositorySerializerBenchmarks/Enhancements/ActXMLSerializer.cs#L109 

Add curly braces around the nested statement(s) in this 'if' block.

Check failure on line 119 in Ginger/RepositorySerializerBenchmarks/Enhancements/ActXMLSerializer.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Ginger/RepositorySerializerBenchmarks/Enhancements/ActXMLSerializer.cs#L119 

Add curly braces around the nested statement(s) in this 'if' block.

Check failure on line 128 in Ginger/RepositorySerializerBenchmarks/Enhancements/ActXMLSerializer.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Ginger/RepositorySerializerBenchmarks/Enhancements/ActXMLSerializer.cs#L128 

Add curly braces around the nested statement(s) in this 'if' block.

Check failure on line 161 in Ginger/RepositorySerializerBenchmarks/Enhancements/ActXMLSerializer.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Ginger/RepositorySerializerBenchmarks/Enhancements/ActXMLSerializer.cs#L161 

Add curly braces around the nested statement(s) in this 'if' block.

Check failure on line 227 in Ginger/RepositorySerializerBenchmarks/Enhancements/ActXMLSerializer.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Ginger/RepositorySerializerBenchmarks/Enhancements/ActXMLSerializer.cs#L227 

Add curly braces around the nested statement(s) in this 'foreach' block.

Check failure on line 85 in Ginger/RepositorySerializerBenchmarks/Enhancements/ActivitiesGroupXMLSerializer.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Ginger/RepositorySerializerBenchmarks/Enhancements/ActivitiesGroupXMLSerializer.cs#L85 

Add curly braces around the nested statement(s) in this 'if' block.

Check failure on line 70 in Ginger/RepositorySerializerBenchmarks/Enhancements/ActivityIdentifiersXMLSerializer.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Ginger/RepositorySerializerBenchmarks/Enhancements/ActivityIdentifiersXMLSerializer.cs#L70 

Add curly braces around the nested statement(s) in this 'if' block.

Check failure on line 31 in Ginger/RepositorySerializerBenchmarks/Enhancements/ActivityXMLSerializer.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Ginger/RepositorySerializerBenchmarks/Enhancements/ActivityXMLSerializer.cs#L31 

Add curly braces around the nested statement(s) in this 'if' block.

Check failure on line 46 in Ginger/RepositorySerializerBenchmarks/Enhancements/ActivityXMLSerializer.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Ginger/RepositorySerializerBenchmarks/Enhancements/ActivityXMLSerializer.cs#L46 

Add curly braces around the nested statement(s) in this 'if' block.

Check failure on line 102 in Ginger/RepositorySerializerBenchmarks/Enhancements/ActivityXMLSerializer.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Ginger/RepositorySerializerBenchmarks/Enhancements/ActivityXMLSerializer.cs#L102 

Add curly braces around the nested statement(s) in this 'if' block.

Check failure on line 104 in Ginger/RepositorySerializerBenchmarks/Enhancements/ActivityXMLSerializer.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Ginger/RepositorySerializerBenchmarks/Enhancements/ActivityXMLSerializer.cs#L104 

Add curly braces around the nested statement(s) in this 'if' block.

Check failure on line 108 in Ginger/RepositorySerializerBenchmarks/Enhancements/ActivityXMLSerializer.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Ginger/RepositorySerializerBenchmarks/Enhancements/ActivityXMLSerializer.cs#L108 

Add curly braces around the nested statement(s) in this 'if' block.

Check warning on line 172 in Ginger/RepositorySerializerBenchmarks/Enhancements/ActivityXMLSerializer.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Ginger/RepositorySerializerBenchmarks/Enhancements/ActivityXMLSerializer.cs#L172 

'System.Exception' should not be thrown by user code.

Check failure on line 32 in Ginger/RepositorySerializerBenchmarks/Enhancements/BetterRepositorySerializerOld.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Ginger/RepositorySerializerBenchmarks/Enhancements/BetterRepositorySerializerOld.cs#L32 

Add curly braces around the nested statement(s) in this 'else' block.

Check failure on line 436 in Ginger/RepositorySerializerBenchmarks/Enhancements/BusinessFlowXMLSerializer.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Ginger/RepositorySerializerBenchmarks/Enhancements/BusinessFlowXMLSerializer.cs#L436 

Add curly braces around the nested statement(s) in this 'foreach' block.

Check failure on line 41 in Ginger/RepositorySerializerBenchmarks/Enhancements/RepositoryItemHeaderXMLSerializer.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Ginger/RepositorySerializerBenchmarks/Enhancements/RepositoryItemHeaderXMLSerializer.cs#L41 

Add curly braces around the nested statement(s) in this 'if' block.

Check failure on line 65 in Ginger/RepositorySerializerBenchmarks/Enhancements/RepositoryItemHeaderXMLSerializer.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Ginger/RepositorySerializerBenchmarks/Enhancements/RepositoryItemHeaderXMLSerializer.cs#L65 

Add curly braces around the nested statement(s) in this 'if' block.

Check failure on line 61 in Ginger/RepositorySerializerBenchmarks/Enhancements/TargetApplicationXMLSerializer.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Ginger/RepositorySerializerBenchmarks/Enhancements/TargetApplicationXMLSerializer.cs#L61 

Add curly braces around the nested statement(s) in this 'if' block.

Check failure on line 22 in Ginger/RepositorySerializerBenchmarks/Enhancements/VariableXMLSerializer.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Ginger/RepositorySerializerBenchmarks/Enhancements/VariableXMLSerializer.cs#L22 

Add curly braces around the nested statement(s) in this 'if' block.

Check failure on line 42 in Ginger/RepositorySerializerBenchmarks/Enhancements/VariableXMLSerializer.cs

See this annotation in the file changed.

@codacy-production codacy-production / Codacy Static Code Analysis

Ginger/RepositorySerializerBenchmarks/Enhancements/VariableXMLSerializer.cs#L42 

Add curly braces around the nested statement(s) in this 'if' block.
View more details on Codacy Production