Beta branch update before 2024.5 Beta 1 #3980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…zeInTelemetryWindow Enhancement - Show Buffer Size In Telemetry Config Window
…ailsIssueFix BugFix - Null Account Details Issue Fix
…Upgrade-Appium-Solution
…ortLinkResetIssue
Upgrade appium solution
…eportLinkResetIssue Account Report link Reset issue fixed
…eLocatorShouldBeDisabled BugFix - 40481 - Disable by tag name locator
The recent code changes introduce new functionalities for handling AI-generated activities, improve code readability, and remove unused resources. Key enhancements include the addition of new properties and methods for summarizing and managing variables within activities and business flows, as well as updates to string handling and list initialization for better efficiency and readability. Additionally, new test methods have been added to validate these functionalities.
### List of Changes
1. **New Notification for AI-Generated Activities**
- Added a new notification for AI-generated activities in `ActivitiesListViewHelper.cs`.
- **Reference:** `ActivitiesListViewHelper.cs`
2. **Code Cleanup and Formatting**
- Removed an unused `using` directive for `OpenQA.Selenium` in `AddGingerAnalyticsEnvWizard.cs`.
- Fixed indentation in `AddGingerAnalyticsEnvWizard.cs`.
- **Reference:** `AddGingerAnalyticsEnvWizard.cs`
3. **Resource Management**
- Removed several image files from the project in `Ginger.csproj`.
- Added a new image resource `AIBrain.png` and updated the `CopyToOutputDirectory` property for some image resources in `Ginger.csproj`.
- **Reference:** `Ginger.csproj`
4. **Source Control Update**
- Changed the default source control type from SVN to GIT in `SourceControlProjectsPage.xaml.cs`.
- **Reference:** `SourceControlProjectsPage.xaml.cs`
5. **New Image Type Handling**
- Added a new image type `AIActivity` and updated the `ImageMakerControl.xaml.cs` to handle this new type.
- **Reference:** `ImageMakerControl.xaml.cs`, `eImageType.cs`
6. **UI Enhancements**
- Added a copy button to the `ValueExpressionEditorPage.xaml` for copying expressions and calculated values.
- Added methods to handle the copy button click events in `ValueExpressionEditorPage.xaml.cs`.
- **Reference:** `ValueExpressionEditorPage.xaml`, `ValueExpressionEditorPage.xaml.cs`
7. **New Record Type**
- Added a new record type `VariableMinimalRecord` in `General.cs`.
- **Reference:** `General.cs`
8. **Code Optimization**
- Removed an unused `using` directive and added a new one for `Microsoft.CodeAnalysis` in `Activity.cs`.
- Added a new property `VariablesSummary` to `Activity.cs` and `BusinessFlow.cs` to get a summary of variables.
- Added a method `GetInitialValue` to `VariableBase.cs` and its derived classes to get the initial value of variables.
- Updated string concatenation in `ActCliOrchestration.cs` to use single quotes.
- Replaced string comparisons with `nameof` for `eRunStatus.Failed` in `RunSetActionHTMLReportSendEmailOperations.cs`.
- Replaced `new List<int>()` with `[]` for list initialization in `RunSetActionHTMLReportSendEmailOperations.cs`.
- **Reference:** `Activity.cs`, `BusinessFlow.cs`, `VariableBase.cs`, `ActCliOrchestration.cs`, `RunSetActionHTMLReportSendEmailOperations.cs`
9. **Flow Details Expressions**
- Added new flow details expressions for variable summaries in `ValueExpressionRefrences.json`.
- **Reference:** `ValueExpressionRefrences.json`
10. **Value Expression Enhancements**
- Updated `using` directives in `ValueExpression.cs` to include `System.Text.Json` and `System.Text.RegularExpressions`, and removed unused namespaces like `SikuliStandard.sikuli_REST`.
- Reformatted the `rNestedfunc` regex pattern for consistency.
- Made minor formatting adjustments to the `MockdataExpressionExtract` method call.
- Added a new `JsonSerializerOptions` instance named `s_writeOptions` for JSON serialization with indented formatting.
- Updated the `GetValueFromReflection` method to handle serialization of non-string enumerable values to JSON.
- Reformatted several `if` statements for consistency.
- Adjusted error message formatting for clarity.
- Reformatted the `IsQueryFromOldVersion`, `GetEnvAppFromEnvURL`, and `GetEnvAppAndParam` methods for consistency.
- Refactored the `PasswordCalculation` method for better readability and consistency.
- Made minor formatting adjustments to the `Mockdata` class.
- **Reference:** `ValueExpression.cs`
11. **Null Check Simplification**
- Simplified null checks using the null-conditional operator for `LocalGingerGrid` and `TelemetryQueueManager` in `WorkSpace.cs`.
- **Reference:** `WorkSpace.cs`
12. **Test Enhancements**
- Updated `using` directives in `ValueExpressionTest.cs` to include `GingerCore.Variables`.
- Added several new test methods to validate the functionality of variable summaries and other features:
- `BusinessFlowVariableSummary`
- `ActivityVariableSummary`
- `PreviousBusinessFlowVariableSummary`
- `PreviousActivityVariableSummary`
- `LastBusinessflowFailedVariablesSummary`
- `LastActivityFailedVariablesSummary`
- `ErrorHandlerActivityVariablesSummary`
- Included assertions in the new test methods to verify the correct JSON serialization of variable summaries.
- **Reference:** `ValueExpressionTest.cs`
…-Automation/Ginger into Releases/Official-Release
…Upgrade-Appium-Solution
…leMovingMappedElements BugFix - 40687 - crash while moving mapped elements
…tRunset cleanup and error handler activity
…ryFix Shared repository Variable duplicate fix, Re run Failed fix and Edge …
Restore Original Scroll Position After Full Page Screenshot
Add Ability to Choose Page Scroll Alignment
Refactor GitHub Actions workflow for CD
…lines Remove unused Azure Pipelines configuration files
…Project ALM - Project Migration
…ObjectRepository Feature - Import katalon object repository
…Session Enhancement - Execution Session
…eActionsMigration Non UI Actions Migration from GingerCore to GingerCoreNet
|
Important Review skippedMore than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review. 133 files out of 285 files are above the max files limit of 75. Please upgrade to Pro plan to get higher limits. You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Maheshkale447
had a problem deploying
to
Deploy
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution.
Before submitting this PR, please make sure: