F fix pan conversion rate #604
Conversation
| in: 'query', | ||
| description: 'could be hourly', | ||
| }, | ||
| ], |
There was a problem hiding this comment.
@aminlatifi
it's not related to conversion rate, but I think it was good to refactor this part
|
@aminlatifi but if you have any idea I can implement it ( I didn't find any good solution) |
src/utils/tokenHelper.js
Outdated
| @@ -41,9 +41,32 @@ function getTokenBySymbol(symbol) { | |||
| return tokensBySymbols[symbol] || { symbol }; | |||
| } | |||
|
|
|||
| const isSymbolInTokenWhitelist = symbol => { | |||
| return Boolean( | |||
There was a problem hiding this comment.
Let's create a set which includes the symbols. The set should be initialized once when the application start
There was a problem hiding this comment.
@aminlatifi done
src/utils/tokenHelper.js
Outdated
| const getValidSymbols = () => { | ||
| const symbols = []; | ||
| getWhiteListTokens().forEach(token => { | ||
| if (!symbols.includes(token.symbol)) { |
There was a problem hiding this comment.
The same set can be used here too
There was a problem hiding this comment.
@aminlatifi done
related to #587, Giveth/giveth-dapp#2286