Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zwavejs2mqtt #1619

Closed
wants to merge 294 commits into from
Closed

Zwavejs2mqtt #1619

wants to merge 294 commits into from

Conversation

rpochet
Copy link
Contributor

@rpochet rpochet commented Oct 11, 2022

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • [ x] If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • [ x] Is the linter passing? (npm run eslint on both front/server)
  • [ x] Did you run prettier? (npm run prettier on both front/server)
  • [x ] If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • [ x] Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community for testing before merging.
  • [ x] If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Migration of Zwave integration from OpenZwave to ZwaveJs via ZwaveJs2Mqtt

@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (cfbb25b) 98.17% compared to head (af80a83) 98.19%.

Files Patch % Lines
...ve-js-ui/lib/commands/installZwaveJSUIContainer.js 95.58% 3 Missing ⚠️
server/services/zwave-js-ui/lib/utils/bindValue.js 94.11% 2 Missing ⚠️
...erver/services/zwave-js-ui/lib/commands/connect.js 99.08% 1 Missing ⚠️
...rver/services/zwave-js-ui/lib/commands/getNodes.js 97.82% 1 Missing ⚠️
...rvices/zwave-js-ui/lib/events/handleMqttMessage.js 98.68% 1 Missing ⚠️
...rver/services/zwave-js-ui/lib/events/valueAdded.js 97.22% 1 Missing ⚠️
...er/services/zwave-js-ui/lib/events/valueUpdated.js 96.29% 1 Missing ⚠️
...erver/services/zwave-js-ui/lib/utils/externalId.js 92.85% 1 Missing ⚠️
...services/zwave-js-ui/lib/utils/transformClasses.js 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1619      +/-   ##
==========================================
+ Coverage   98.17%   98.19%   +0.01%     
==========================================
  Files         776      804      +28     
  Lines       12176    12963     +787     
==========================================
+ Hits        11954    12729     +775     
- Misses        222      234      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rpochet
Copy link
Contributor Author

rpochet commented Nov 8, 2022

Bonjour,

J'essaye de créer des tests pour les installations docker, mais j'ai un soucis car la méthode exec n'est pas un mock comme cela se produit pour les tests zigbee2mqtt (tests dont je suis basé en grande partie)

Quelqu'un pourrait m'aider?

@Pierre-Gilles
Copy link
Contributor

@rpochet c'est la question que tu as posé sur le forum? Je t'ai répondu là bas: https://community.gladysassistant.com/t/v4-integration-z-wave/6057/146?u=pierre-gilles

N'hésite pas si tu as besoin qu'on s'appelle :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants