-
-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ecovacs #1712
Ecovacs #1712
Conversation
… CoverDeviceFeature
…improvment and fixes (DeviceBox)
@ngeissel if you need functional test, I've ecovacs deebot. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1712 +/- ##
==========================================
+ Coverage 98.40% 98.42% +0.01%
==========================================
Files 858 879 +21
Lines 14081 14317 +236
==========================================
+ Hits 13857 14091 +234
- Misses 224 226 +2 ☔ View full report in Codecov by Sentry. |
…tribute is used to give the ecovacs service connection status + use getVacbotFromExternalId method
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Pull Request check-list
To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:
npm test
on both front/server)npm run eslint
on both front/server)npm run prettier
on both front/server)npm run compare-translations
on front)front/src/config/demo.js
) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Description of change
Add Ecovacs service that allows to add vacbots in Gladys. It handles basic commands as : clean, pause, stop, return to charge station. It returns : batery level and clean reports. It also add to gladys a brand new vacbot box (regrouping all main function in only one box).
More information here :https://github.com/ngeissel/Gladys/tree/ecovacs/server/services/ecovacs.