Use device feature for scene action of type turn on/off light/switch

[rpochet]

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

• If your changes affects code, did your write the tests?
• Are tests passing? (npm test on both front/server)
• [x ] Is the linter passing? (npm run eslint on both front/server)
• [ x] Did you run prettier? (npm run prettier on both front/server)
• If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
• [ x] Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community for testing before merging.
• If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
• If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
• Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

In scene, provide selection of device feature instance of device in 'Turn ON/OFF light/switch' actions.

Before:

New proposal:

[codecov]

Codecov Report

All modified lines are covered by tests ✅

Files	Coverage Δ
server/lib/scene/scene.actions.js	97.39% <100.00%> (-1.00%)	⬇️

... and 30 files with indirect coverage changes

📢 Thoughts on this report? Let us know!.

[Pierre-Gilles]

Thanks for the PR, it works fine on my side ! great work 👏

You need to write a DB migration to update all existing scenes, otherwise all the scene already working will stop working for existing Gladys users.

I wrote other feedbacks in the code.

[rpochet]

You need to write a DB migration to update all existing scenes, otherwise all the scene already working will stop working for existing Gladys users.

How can I test DB migration?

[Pierre-Gilles]

@rpochet Currently we don't have any ways to unit test data migration

I bet you could write a unit test importing a migration file and then calling the up function if you want to ? :)

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[relativeci]

Job #1907: Bundle Size — 8.82MiB (~+0.01%).

7ba4b26(current) vs 04f331d master#1902(baseline)

Warning

Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics   2 changes 1 regression

	Current Job #1907	Baseline Job #1902
Initial JS	4.77MiB(+0.02%)	4.77MiB
Initial CSS	301.31KiB	301.31KiB
Cache Invalidation	53.91%	0%
Chunks	48	48
Assets	152	152
Modules	1377	1377
Duplicate Modules	19	19
Duplicate Code	0.69%	0.69%
Packages	124	124
Duplicate Packages	3	3

Bundle size by type   1 change 1 regression

	Current Job #1907	Baseline Job #1902
JS	6.39MiB (+0.01%)	6.39MiB
IMG	2MiB	2MiB
CSS	316.97KiB	316.97KiB
Fonts	93.55KiB	93.55KiB
Other	15.48KiB	15.48KiB
HTML	13.58KiB	13.58KiB

---

View job #1907 report View rpochet:scene_device_feature branch activity