Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sunspec #1784

Closed
wants to merge 88 commits into from
Closed

Sunspec #1784

wants to merge 88 commits into from

Conversation

rpochet
Copy link
Contributor

@rpochet rpochet commented May 13, 2023

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • [ x] Is the linter passing? (npm run eslint on both front/server)
  • [ x] Did you run prettier? (npm run prettier on both front/server)
  • [ x] If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • [ x] Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community for testing before merging.
  • If your changes modify the API (REST or Node.js), did you modify the API documentation? (Documentation is based on comments in code)
  • If you are adding a new features/services which needs explanation, did you modify the user documentation? See the GitHub repo and the website.
  • Did you add fake requests data for the demo mode (front/src/config/demo.js) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Add support for Photovoltaic device according to SunSpec protocol

@codecov
Copy link

codecov bot commented May 13, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (30ce850) 98.17% compared to head (ea11d28) 98.17%.
Report is 40 commits behind head on master.

Files Patch % Lines
server/services/sunspec/lib/sunspec.scan.js 94.73% 3 Missing ⚠️
server/services/sunspec/lib/sunspec.connect.js 89.47% 2 Missing ⚠️
server/services/sunspec/lib/bdpv/sunspec.bdpv.js 96.96% 1 Missing ⚠️
...services/sunspec/lib/utils/sunspec.ModbusClient.js 98.38% 1 Missing ⚠️
...services/sunspec/lib/utils/sunspec.ModelFactory.js 98.61% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master    #1784    +/-   ##
========================================
  Coverage   98.17%   98.17%            
========================================
  Files         773      795    +22     
  Lines       12133    12608   +475     
========================================
+ Hits        11911    12378   +467     
- Misses        222      230     +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

stale bot commented Jan 26, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 26, 2024
@stale stale bot closed this Feb 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant