Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase session validity for local users #1882

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

Pierre-Gilles
Copy link
Contributor

@Pierre-Gilles Pierre-Gilles commented Sep 18, 2023

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)

Description of change

Increase session validity

@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: febc9a3
Status: ✅  Deploy successful!
Preview URL: https://b66242a5.gladys-plus.pages.dev
Branch Preview URL: https://increase-session-validity-lo.gladys-plus.pages.dev

View logs

@relativeci
Copy link

relativeci bot commented Sep 18, 2023

Job #1808: Bundle Size — 8.66MiB (0%).

febc9a3(current) vs b998ccb master#1795(baseline)

⚠️ Bundle contains 4 duplicate packages

Metrics (1 change)
                 Current
Job #1808
     Baseline
Job #1795
Initial JS 4.69MiB 4.69MiB
Initial CSS 299.99KiB 299.99KiB
Cache Invalidation 0% 54.04%
Chunks 48 48
Assets 151 151
Modules 1361 1361
Duplicate Modules 19 19
Duplicate Code 0.69% 0.69%
Packages 124 124
Duplicate Packages 4 4
Total size by type (no changes)
                 Current
Job #1808
     Baseline
Job #1795
CSS 315.65KiB 315.65KiB
Fonts 93.55KiB 93.55KiB
HTML 13.58KiB 13.58KiB
IMG 1.92MiB 1.92MiB
JS 6.31MiB 6.31MiB
Media 0B 0B
Other 15.4KiB 15.4KiB

View job #1808 reportView increase-session-validity-local branch activity

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Patch coverage is 100.00% of modified lines.

Files Changed Coverage
server/api/controllers/user.controller.js 100.00%

📢 Thoughts on this report? Let us know!.

@Pierre-Gilles Pierre-Gilles merged commit 594fa48 into master Sep 18, 2023
@Pierre-Gilles Pierre-Gilles deleted the increase-session-validity-local branch September 18, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant