Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User can define the threshold of the room temperature #1888

Merged
merged 4 commits into from
Sep 28, 2023

Conversation

callemand
Copy link
Contributor

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (french forum/english forum) for testing before merging.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Add a threshold for the room temperature widget

Screenshot 2023-09-21 at 14 15 22 Screenshot 2023-09-21 at 14 15 11 Screenshot 2023-09-21 at 14 14 49 Screenshot 2023-09-21 at 14 14 26 Screenshot 2023-09-21 at 14 14 18

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
server/models/dashboard.js 100.00% <ø> (ø)
server/utils/constants.js 100.00% <100.00%> (ø)

📢 Thoughts on this report? Let us know!.

@relativeci
Copy link

relativeci bot commented Sep 21, 2023

Job #1841: Bundle Size — 8.7MiB (+0.09%).

b7e5ee9(current) vs 0bff5d6 master#1837(baseline)

⚠️ Bundle contains 3 duplicate packages

Metrics (4 changes)
                 Current
Job #1841
     Baseline
Job #1837
Initial JS 4.72MiB(+0.11%) 4.72MiB
Initial CSS 301.15KiB(+0.19%) 300.58KiB
Cache Invalidation 67.38% 54.19%
Chunks 48 48
Assets 151 151
Modules 1362(+0.07%) 1361
Duplicate Modules 19 19
Duplicate Code 0.69% 0.69%
Packages 124 124
Duplicate Packages 3 3
Total size by type (2 changes)
                 Current
Job #1841
     Baseline
Job #1837
CSS 316.81KiB (+0.18%) 316.24KiB
Fonts 93.55KiB 93.55KiB
HTML 13.58KiB 13.58KiB
IMG 1.92MiB 1.92MiB
JS 6.34MiB (+0.11%) 6.34MiB
Media 0B 0B
Other 15.4KiB 15.4KiB

View job #1841 reportView callemand:min_max_temp branch activity

Copy link
Contributor

@Pierre-Gilles Pierre-Gilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👏 Great work!

@Pierre-Gilles Pierre-Gilles merged commit 2f902a6 into GladysAssistant:master Sep 28, 2023
9 checks passed
@callemand callemand deleted the min_max_temp branch September 28, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants