Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add energy value from tuya devices #1898

Merged
merged 3 commits into from
Oct 16, 2023

Conversation

callemand
Copy link
Contributor

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (french forum/english forum) for testing before merging.

Description of change

Just adding energy value from tuya switch device

@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

All modified lines are covered by tests ✅

Files Coverage Δ
...ver/services/tuya/lib/device/tuya.convertDevice.js 100.00% <100.00%> (ø)
...ver/services/tuya/lib/device/tuya.deviceMapping.js 100.00% <100.00%> (ø)

📢 Thoughts on this report? Let us know!.

@relativeci
Copy link

relativeci bot commented Sep 25, 2023

Job #1923: Bundle Size — 8.82MiB (0%).

141afef(current) vs 33b2264 master#1922(baseline)

Warning

Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  no changes
                 Current
Job #1923
     Baseline
Job #1922
No change  Initial JS 4.77MiB 4.77MiB
No change  Initial CSS 301.31KiB 301.31KiB
No change  Cache Invalidation 0% 0%
No change  Chunks 48 48
No change  Assets 152 152
No change  Modules 1377 1377
No change  Duplicate Modules 19 19
No change  Duplicate Code 0.69% 0.69%
No change  Packages 124 124
No change  Duplicate Packages 3 3
Bundle size by type  no changes
                 Current
Job #1923
     Baseline
Job #1922
Not changed  JS 6.39MiB 6.39MiB
Not changed  IMG 2MiB 2MiB
Not changed  CSS 316.97KiB 316.97KiB
Not changed  Fonts 93.55KiB 93.55KiB
Not changed  Other 15.48KiB 15.48KiB
Not changed  HTML 13.58KiB 13.58KiB

View job #1923 reportView callemand:add_energy_tuya branch activity

Pierre-Gilles
Pierre-Gilles previously approved these changes Oct 16, 2023
Copy link
Contributor

@Pierre-Gilles Pierre-Gilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me!

@Pierre-Gilles Pierre-Gilles merged commit 6f78b63 into GladysAssistant:master Oct 16, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants