Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat zigbee2mqtt usb change #1905

Merged

Conversation

cicoub13
Copy link
Contributor

Fixes #1887

Adding a system.inspectContainer(containerId) was needed to compare Devices[0].PathOnHost

Under testing in real use cases

@cicoub13 cicoub13 marked this pull request as draft September 29, 2023 16:11
@cicoub13 cicoub13 force-pushed the feat-zigbee2mqtt-usb-change branch 2 times, most recently from 3656072 to 36f894c Compare September 29, 2023 16:26
@codecov
Copy link

codecov bot commented Sep 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
server/lib/system/index.js 100.00% <100.00%> (ø)
server/lib/system/system.getContainers.js 100.00% <ø> (ø)
server/lib/system/system.inspectContainer.js 100.00% <100.00%> (ø)
...er/services/zigbee2mqtt/lib/installZ2mContainer.js 100.00% <100.00%> (ø)

📢 Thoughts on this report? Let us know!.

@cicoub13 cicoub13 force-pushed the feat-zigbee2mqtt-usb-change branch 3 times, most recently from f1a8f1d to 1b3aa5b Compare September 30, 2023 20:12
@cicoub13 cicoub13 marked this pull request as ready for review September 30, 2023 20:27
@relativeci
Copy link

relativeci bot commented Sep 30, 2023

Job #1941: Bundle Size — 8.82MiB (0%).

b79005b(current) vs f87a192 master#1925(baseline)

Warning

Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  no changes
                 Current
Job #1941
     Baseline
Job #1925
No change  Initial JS 4.77MiB 4.77MiB
No change  Initial CSS 301.31KiB 301.31KiB
Change  Cache Invalidation 0% 53.91%
No change  Chunks 48 48
No change  Assets 152 152
No change  Modules 1377 1377
No change  Duplicate Modules 19 19
No change  Duplicate Code 0.69% 0.69%
No change  Packages 124 124
No change  Duplicate Packages 3 3
Bundle size by type  no changes
                 Current
Job #1941
     Baseline
Job #1925
Not changed  JS 6.39MiB 6.39MiB
Not changed  IMG 2MiB 2MiB
Not changed  CSS 316.97KiB 316.97KiB
Not changed  Fonts 93.55KiB 93.55KiB
Not changed  Other 15.48KiB 15.48KiB
Not changed  HTML 13.58KiB 13.58KiB

View job #1941 reportView cicoub13:feat-zigbee2mqtt-usb-ch... branch activity

Pierre-Gilles
Pierre-Gilles previously approved these changes Oct 16, 2023
Copy link
Contributor

@Pierre-Gilles Pierre-Gilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I think we should have more real world testing on this!

Copy link
Contributor

@Pierre-Gilles Pierre-Gilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is those files in the PR?

Screenshot 2023-10-20 at 14 33 27

@cicoub13
Copy link
Contributor Author

cicoub13 commented Oct 20, 2023

What is those files in the PR?

They are coming from an interrupted test. I removed them and added to .gitignore

@cicoub13 cicoub13 force-pushed the feat-zigbee2mqtt-usb-change branch from 7d02bee to b79005b Compare October 20, 2023 12:46
Copy link
Contributor

@Pierre-Gilles Pierre-Gilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! 🙏

@Pierre-Gilles Pierre-Gilles merged commit cc4f4d9 into GladysAssistant:master Oct 20, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Zigbee2Mqtt] Changing Dongle port requires deactivation/reactivation of service to be taken in account
2 participants