-
-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat zigbee2mqtt usb change #1905
Feat zigbee2mqtt usb change #1905
Conversation
3656072
to
36f894c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
📢 Thoughts on this report? Let us know!. |
f1a8f1d
to
1b3aa5b
Compare
Job #1941: Bundle Size — 8.82MiB (0%).
Warning Bundle contains 3 duplicate packages – View duplicate packages Bundle metrics
|
Current Job #1941 |
Baseline Job #1925 |
|
---|---|---|
4.77MiB |
4.77MiB |
|
301.31KiB |
301.31KiB |
|
0% |
53.91% |
|
48 |
48 |
|
152 |
152 |
|
1377 |
1377 |
|
19 |
19 |
|
0.69% |
0.69% |
|
124 |
124 |
|
3 |
3 |
Bundle size by type no changes
Current Job #1941 |
Baseline Job #1925 |
|
---|---|---|
6.39MiB |
6.39MiB |
|
2MiB |
2MiB |
|
316.97KiB |
316.97KiB |
|
93.55KiB |
93.55KiB |
|
15.48KiB |
15.48KiB |
|
13.58KiB |
13.58KiB |
View job #1941 report View cicoub13:feat-zigbee2mqtt-usb-ch... branch activity
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but I think we should have more real world testing on this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1b3aa5b
to
7d02bee
Compare
They are coming from an interrupted test. I removed them and added to |
7d02bee
to
b79005b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! 🙏
Fixes #1887
Adding a system.inspectContainer(containerId) was needed to compare Devices[0].PathOnHost
Under testing in real use cases