-
-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP : chore: Update EditChart component to include device features threshold options #2118
base: master
Are you sure you want to change the base?
WIP : chore: Update EditChart component to include device features threshold options #2118
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2118 +/- ##
=======================================
Coverage 98.48% 98.48%
=======================================
Files 867 867
Lines 14187 14209 +22
=======================================
+ Hits 13972 13994 +22
Misses 215 215 ☔ View full report in Codecov by Sentry. |
#2801 Bundle Size — 10.26MiB (+0.24%).b9c81d4(current) vs b8ab133 master#2800(baseline) Warning Bundle contains 3 duplicate packages – View duplicate packages Bundle metrics
|
Current #2801 |
Baseline #2800 |
|
---|---|---|
Initial JS | 5.56MiB (+0.44% ) |
5.54MiB |
Initial CSS | 304.83KiB (+0.05% ) |
304.68KiB |
Cache Invalidation | 56.89% |
0% |
Chunks | 51 |
51 |
Assets | 171 |
171 |
Modules | 1493 (+0.07% ) |
1492 |
Duplicate Modules | 21 |
21 |
Duplicate Code | 0.83% |
0.83% |
Packages | 124 |
124 |
Duplicate Packages | 3 |
3 |
Bundle size by type 2 changes
2 regressions
Current #2801 |
Baseline #2800 |
|
---|---|---|
JS | 7.35MiB (+0.34% ) |
7.32MiB |
IMG | 2.48MiB |
2.48MiB |
CSS | 321.62KiB (+0.05% ) |
321.47KiB |
Fonts | 93.55KiB |
93.55KiB |
Other | 17.62KiB |
17.62KiB |
HTML | 13.58KiB |
13.58KiB |
Bundle analysis report Branch Terdious:add-fixed-or-variable-t... Project dashboard
Generated by RelativeCI Documentation Report issue
…d options
Pull Request check-list
To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:
npm test
on both front/server)npm run eslint
on both front/server)npm run prettier
on both front/server)npm run compare-translations
on front)front/src/config/demo.js
) so that the demo website is working without a backend? (if needed) See https://demo.gladysassistant.com.NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Description of change
https://community.gladysassistant.com/t/pouvoir-avoir-une-courbe-meme-si-la-valeur-ne-bouge-pas/9074