Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update device feature label input placeholder #2127

Conversation

Terdious
Copy link
Contributor

@Terdious Terdious commented Oct 7, 2024

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (french forum/english forum) for testing before merging.

NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.

Description of change

Fix: When you want to change the name of a feature in the charts and you completely delete the input field, it fills again with the original name of the feature. It's annoying!
https://community.gladysassistant.com/t/gladys-assistant-4-46-les-tableaux-de-bords/9112/3?u=terdious
https://community.gladysassistant.com/t/gladys-assistant-4-46-les-tableaux-de-bords/9112/5?u=terdious

and other Fix: when multiple devices present, deleting a device replaced the name of the next device

@Terdious Terdious requested a review from Pierre-Gilles October 7, 2024 13:45
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.48%. Comparing base (7fce024) to head (545503b).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2127   +/-   ##
=======================================
  Coverage   98.48%   98.48%           
=======================================
  Files         867      867           
  Lines       14187    14187           
=======================================
  Hits        13972    13972           
  Misses        215      215           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

relativeci bot commented Oct 7, 2024

#2768 Bundle Size — 10.23MiB (-0.02%).

545503b(current) vs 7fce024 master#2767(baseline)

Warning

Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  Change 4 changes Regression 1 regression Improvement 1 improvement
                 Current
#2768
     Baseline
#2767
Improvement  Initial JS 5.54MiB(-0.05%) 5.54MiB
Regression  Initial CSS 304.68KiB(+0.02%) 304.63KiB
Change  Cache Invalidation 56.93% 0%
No change  Chunks 51 51
No change  Assets 171 171
Change  Modules 1490(-0.13%) 1492
No change  Duplicate Modules 21 21
No change  Duplicate Code 0.83% 0.83%
No change  Packages 124 124
No change  Duplicate Packages 3 3
Bundle size by type  Change 2 changes Regression 1 regression Improvement 1 improvement
                 Current
#2768
     Baseline
#2767
Improvement  JS 7.32MiB (-0.03%) 7.32MiB
No change  IMG 2.48MiB 2.48MiB
Regression  CSS 321.47KiB (+0.02%) 321.42KiB
No change  Fonts 93.55KiB 93.55KiB
No change  Other 17.62KiB 17.62KiB
No change  HTML 13.58KiB 13.58KiB

Bundle analysis reportBranch Terdious:input-clear-default-val...Project dashboard


Generated by RelativeCIDocumentationReport issue

Copy link
Contributor

@Pierre-Gilles Pierre-Gilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi ! Thanks for this PR 🙏

If I remove the label then save, I get an error :

Kapture.2024-10-09.at.09.47.35.mp4

@Terdious
Copy link
Contributor Author

If I remove the label then save, I get an error :

@Pierre-Gilles, tell me if this suits you, I took the following part:

  • When you empty the field, it turns red with a shadow to warn.
    image

  • If you leave it like this and you no longer focus, it remains in a red frame
    image

  • If you save, it keeps the last name saved but authorizes the saving.
    This avoids specific error management, and no longer breaks the saving. But there is less information. Does this suit you anyway?

Otherwise I see for a specific error management that I had started before, but we agree that in this case it must be managed in front/src/routes/dashboard/edit-dashboard/index.js? To be sure ^^

Copy link
Contributor

@Pierre-Gilles Pierre-Gilles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, works fine on my side! 👏

@Pierre-Gilles Pierre-Gilles merged commit e27288e into GladysAssistant:master Oct 11, 2024
9 checks passed
@Terdious Terdious deleted the input-clear-default-value-DeviceListWithDragAndDrop branch October 11, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants