-
-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update device feature label input placeholder #2127
fix: Update device feature label input placeholder #2127
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2127 +/- ##
=======================================
Coverage 98.48% 98.48%
=======================================
Files 867 867
Lines 14187 14187
=======================================
Hits 13972 13972
Misses 215 215 ☔ View full report in Codecov by Sentry. |
#2768 Bundle Size — 10.23MiB (-0.02%).545503b(current) vs 7fce024 master#2767(baseline) Warning Bundle contains 3 duplicate packages – View duplicate packages Bundle metrics
|
Current #2768 |
Baseline #2767 |
|
---|---|---|
Initial JS | 5.54MiB (-0.05% ) |
5.54MiB |
Initial CSS | 304.68KiB (+0.02% ) |
304.63KiB |
Cache Invalidation | 56.93% |
0% |
Chunks | 51 |
51 |
Assets | 171 |
171 |
Modules | 1490 (-0.13% ) |
1492 |
Duplicate Modules | 21 |
21 |
Duplicate Code | 0.83% |
0.83% |
Packages | 124 |
124 |
Duplicate Packages | 3 |
3 |
Bundle size by type 2 changes
1 regression
1 improvement
Current #2768 |
Baseline #2767 |
|
---|---|---|
JS | 7.32MiB (-0.03% ) |
7.32MiB |
IMG | 2.48MiB |
2.48MiB |
CSS | 321.47KiB (+0.02% ) |
321.42KiB |
Fonts | 93.55KiB |
93.55KiB |
Other | 17.62KiB |
17.62KiB |
HTML | 13.58KiB |
13.58KiB |
Bundle analysis report Branch Terdious:input-clear-default-val... Project dashboard
Generated by RelativeCI Documentation Report issue
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi ! Thanks for this PR 🙏
If I remove the label then save, I get an error :
Kapture.2024-10-09.at.09.47.35.mp4
@Pierre-Gilles, tell me if this suits you, I took the following part:
Otherwise I see for a specific error management that I had started before, but we agree that in this case it must be managed in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, works fine on my side! 👏
Pull Request check-list
To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:
npm run eslint
on both front/server)npm run prettier
on both front/server)NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open.
Description of change
Fix: When you want to change the name of a feature in the charts and you completely delete the input field, it fills again with the original name of the feature. It's annoying!
https://community.gladysassistant.com/t/gladys-assistant-4-46-les-tableaux-de-bords/9112/3?u=terdious
https://community.gladysassistant.com/t/gladys-assistant-4-46-les-tableaux-de-bords/9112/5?u=terdious
and other Fix: when multiple devices present, deleting a device replaced the name of the next device