Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Sensitive Data Exposure #2158

Merged
merged 6 commits into from
Nov 8, 2024
Merged

Fix Sensitive Data Exposure #2158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
47145be
Fix Sensitive Data Exposure
bnematzadeh Nov 5, 2024
636ce61
Update user.test.js
bnematzadeh Nov 6, 2024
36ee61e
Update user.test.js
bnematzadeh Nov 8, 2024
6560f0a
Update user.test.js
bnematzadeh Nov 8, 2024
759dea6
Update user.test.js
bnematzadeh Nov 8, 2024
9b42e71
Update user.test.js
bnematzadeh Nov 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions server/lib/user/user.get.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,8 @@ async function get(options) {
if (userPlain.picture && userPlain.picture.toString) {
userPlain.picture = userPlain.picture.toString('utf8');
}
delete userPlain.password;
delete userPlain.telegram_user_id;
return userPlain;
});

Expand Down
16 changes: 16 additions & 0 deletions server/test/security/user.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
const { expect } = require('chai');
const { authenticatedRequest } = require('../controllers/request.test');

describe('/api/v1/user/', () => {
it('should return all users without password', async () => {
await authenticatedRequest
.get('/api/v1/user?fields=password')
.expect('Content-Type', /json/)
.expect(200)
.then((res) => {
res.body.forEach((user) => {
expect(user).to.not.have.property('password');
});
});
});
});
Loading