Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve LAN Manager wording #2174

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Improve LAN Manager wording #2174

merged 1 commit into from
Nov 28, 2024

Conversation

Pierre-Gilles
Copy link
Contributor

Pull Request check-list

To ensure your Pull Request can be accepted as fast as possible, make sure to review and check all of these items:

  • If your changes affects code, did your write the tests?
  • Are tests passing? (npm test on both front/server)
  • Is the linter passing? (npm run eslint on both front/server)
  • Did you run prettier? (npm run prettier on both front/server)
  • If you are adding a new features/services, did you run integration comparator? (npm run compare-translations on front)
  • Did you test this pull request in real life? With real devices? If this development is a big feature or a new service, we recommend that you provide a Docker image to the community (french forum/english forum) for testing before merging.

Description of change

Improve LAN Manager wording

Copy link

Deploying gladys-plus with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7961ac5
Status: ✅  Deploy successful!
Preview URL: https://f5f5b10f.gladys-plus.pages.dev
Branch Preview URL: https://lan-manager-wording.gladys-plus.pages.dev

View logs

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.53%. Comparing base (8fff0ca) to head (7961ac5).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2174   +/-   ##
=======================================
  Coverage   98.53%   98.53%           
=======================================
  Files         875      875           
  Lines       14386    14386           
=======================================
  Hits        14175    14175           
  Misses        211      211           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

relativeci bot commented Nov 28, 2024

#2893 Bundle Size — 10.34MiB (+0.01%).

7961ac5(current) vs 8fff0ca master#2883(baseline)

Warning

Bundle contains 3 duplicate packages – View duplicate packages

Bundle metrics  Change 3 changes Regression 1 regression
                 Current
#2893
     Baseline
#2883
Regression  Initial JS 5.62MiB(+0.03%) 5.62MiB
No change  Initial CSS 304.89KiB 304.89KiB
Change  Cache Invalidation 54.25% 57.81%
No change  Chunks 51 51
No change  Assets 172 172
No change  Modules 1507 1507
No change  Duplicate Modules 21 21
Change  Duplicate Code 0.83%(-1.19%) 0.84%
No change  Packages 124 124
No change  Duplicate Packages 3 3
Bundle size by type  Change 1 change Regression 1 regression
                 Current
#2893
     Baseline
#2883
Regression  JS 7.41MiB (+0.02%) 7.41MiB
No change  IMG 2.49MiB 2.49MiB
No change  CSS 321.68KiB 321.68KiB
No change  Fonts 93.55KiB 93.55KiB
No change  Other 17.7KiB 17.7KiB
No change  HTML 13.58KiB 13.58KiB

Bundle analysis reportBranch lan-manager-wordingProject dashboard


Generated by RelativeCIDocumentationReport issue

@Pierre-Gilles Pierre-Gilles merged commit 5182656 into master Nov 28, 2024
10 checks passed
@Pierre-Gilles Pierre-Gilles deleted the lan-manager-wording branch November 28, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant