test_iostream: refactor SDR input sample test so it can be reused #693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes the SDR input sample test parametrizable. The previous test relied on i_en having to toggle every clock cycle, so to remove that requirement we are now toggling the clk_out output every time i_en is on, and as such the `save_expected_sample_values_tb` testbench must also look at both edges of clk_out in order to determine when we're supposed to sample the signal. Docstrings have also been improved.
purdeaandrei
force-pushed
the
f_refactor_sdr_iostreamer_test
branch
from
87118c2 to
3814e22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a small piece extracted from #678 on the principle that smaller changesets are easier to review.
This change makes the SDR input sample test parametrizable. The previous test relied on i_en having to toggle every clock cycle, so to remove that requirement we are now toggling the clk_out output every time i_en is on, and as such the
save_expected_sample_values_tbtestbench must also look at both edges of clk_out in order to determine when we're supposed to sample the signal.Docstrings have also been improved.
This PR only slightly changes the behavior of the test (because clk_out waveform is now different), however the test coverage remains the same!