Updated homepage with dynamic contributors #31
Conversation
Added script template for use with mustache.js for rendering the dynamic contributors.
Assumed the avatar URL returned by the GitHub API will always have a querystring. It currently does, so I've just appended `s=150` onto the end. When I tested it too, the last value for `s` wins, so if you already have `s=80` already in the URL and we append `s=150` we'll get 150x150 pixel images. Removed _Contributors.cshtml, as all the HTML for this has been moved into the Mustache script template that sits in Views/Home/Index.cshtml. I've added an octocat background image to the #contributors element so that something is displayed while we're loading the contributors via the API. I've also updated the CSS for the contributors list, so that it displays the same way as the current homepage is displayed.
When the contributors are loaded via Ajax, CSS transitions are used to fade out the octocat image and fade in the contributors. Mustache template updated to handle cases where a user doesn't have their Twitter username associated with their GitHub account.
|
Thanks Ian. I will have a look at it this weekend! On Friday, January 31, 2014, Ian Oxley notifications@github.com wrote:
|
|
This looks and works great! Thanks Ian. I won't merge it in just yet. I see the less file overwrote some changes that were made to the CSS file a while back. Does your packages page also not look right? I will try and address this and then merge this in. |
|
It should've only been the contributors LESS / CSS that changed. I'll double-check and let you know. Is it just the packages page that seems to be affected? On 2 Feb 2014, at 18:34, Björn Holdt notifications@github.com wrote:
|
|
You are right, this is what should have happened. However, a number of changes were made on the global.css file without updating the less file. These changes are now being overwritten. (Have a look at #30 for a discussion on this). So for the time being, I can only recommend you doing the changes in the CSS file. @avanderhoorn what's your call on this with the new site? Worthwhile re-opening #30 or just work with this until the new site is launched? |
|
I would say that it would be worth waiting for the new bits to come through. The redesign has been delayed a little due to the release that we have been working towards that will go out today. Once that is out, the redesign is the main thing that we will be focusing on. Given that, I'm hoping that it wont be more than a week till we get it to you. |
|
Ok great. @ianoxley are you happy to just add the changes to CSS file or would you like me to have a look at it? After that we can merge this in and be good to see how it works until the new site goes live. |
|
I'll have a look and see what I can do. |
Checked out global.css from commit 5fe162a, then added the changes made to global.less directly to global.css. Increased the width of the dl lists on the plugins page to fix a layout issue.
The contributors on the homepage are now displayed dynamically, as discussed in #25, using @bholdt's server-side changes from #28.