Use OptionParser to parse component #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
nappex
force-pushed
the
use-optionParser
branch
from
9f789ca to
cc58c7f
Compare
Glutexo
approved these changes
Oct 15, 2023
| @@ -21,16 +21,20 @@ defmodule OnigumoCLITest do | |||
| Onigumo.CLI.main(["Downloader"]) | |||
| end | |||
|
|
|||
| test("run CLI with unknown argument") do | |||
| test("run CLI with invalid argument") do | |||
There was a problem hiding this comment.
Maybe this is a separate change, but I see the change for consistency with the new “invalid switch” tests. It is okay to have it here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #162
fix #188
I'be tried to be really consistent with existing code and make really the smallest diff as possible.
That's the one of reasons why I parse the component as positional arguments.
Nice thing was appeared, the
OptionParseris not so good in parsing the positional arguments and its main goal is parsingswitches(resp.options).IMHO it is emphased by warning which you get from elixir, when you do not pass
:switchesor:strict, but these are required only forswitches.