Skip to content

Commit

Permalink
Clarified a confusing field name in JSON logs
Browse files Browse the repository at this point in the history
  • Loading branch information
obilodeau committed May 31, 2024
1 parent e98ddec commit 7f766be
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.adoc
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ For a detailed view of what has changed, refer to the {uri-repo}/commits/master[
=== Enhancements

* Handles unknown NTSTATUS gracefully ({uri-issue}471[#471])
* JSON logs field change: data becomes exceptionData


== v2.1.0 - 2024-01-23
Expand Down
2 changes: 1 addition & 1 deletion pyrdp/layer/tcp.py
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ def dataReceived(self, data: bytes):
if isinstance(e, ParsingError):
self.log.error("Parser information: %(parserInfo)s", {"parserInfo": e.formatLayer(len(e.layers) - 1)})

self.log.error("Exception occurred when receiving: %(data)s" , {"data": hexlify(data).decode()})
self.log.error("Exception occurred when receiving: %(exceptionData)s" , {"exceptionData": hexlify(data).decode()})

raise

Expand Down
2 changes: 1 addition & 1 deletion pyrdp/parser/rdp/fastpath.py
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ def parseEvents(self, data: bytes) -> List[FastPathEvent]:
except KeyboardInterrupt:
raise
except Exception:
log.error("Exception occurred when receiving: %(data)s", {"data": hexlify(eventData)})
log.error("Exception occurred when receiving: %(exceptionData)s", {"exceptionData": hexlify(eventData)})
raise

events.append(event)
Expand Down

0 comments on commit 7f766be

Please sign in to comment.