Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IWB-2: added blacklist management functionality #292

Merged
merged 22 commits into from
Aug 13, 2024
Merged

IWB-2: added blacklist management functionality #292

merged 22 commits into from
Aug 13, 2024

Conversation

FrankreedX
Copy link
Contributor

This is a crude effort. I'm aware of the lack of polish.
Some features that will be added in a future PR:

  • Loading spinner
  • Bulk removal (probably will replace the current unban buttons) + big unban button at the bottom
  • Snackbar

@FrankreedX
black list feature works
ac7e815
@FrankreedX
Merge branch 'frankreed/foreignManagement1_blacklist_hook' into frank…
999af90 
…reed/foreignManagement2_blacklist_tab
@FrankreedX
some unused stuff removal
9fa672f
@FrankreedX
simplified removeBlacklist.js
f5a1855
@FrankreedX
Merge branch 'frankreed/foreignManagement1_blacklist_hook' into frank…
4f5ac10 
…reed/foreignManagement2_blacklist_tab
@FrankreedX
Merge branch 'frankreed/foreignManagement1_blacklist_hook' into frank…
6ac7af1 
…reed/foreignManagement2_blacklist_tab
@FrankreedX
Merge branch 'frankreed/foreignManagement1_blacklist_hook' into frank…
52b16f8 
…reed/foreignManagement2_blacklist_tab
@FrankreedX
Merge branch 'frankreed/foreignManagement1_blacklist_hook' into frank…
54469bf 
…reed/foreignManagement2_blacklist_tab
@FrankreedX
Merge branch 'frankreed/foreignManagement1_blacklist_hook' into frank…
51e60d3 
…reed/foreignManagement2_blacklist_tab
Gehrkej
Gehrkej requested changes Aug 4, 2024
View reviewed changes
Copy link
Contributor

@Gehrkej Gehrkej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the approach you took with the user management stuff! Just a couple small changes and tracking down a UI bug that might've been caused from testing

app/content/team/index.js Show resolved Hide resolved
app/segments/(team)/manageForeignRequests.js Outdated Show resolved Hide resolved
app/segments/(team)/blacklist.js Outdated Show resolved Hide resolved
dbOperations/removeBlacklist.js Outdated Show resolved Hide resolved
update_unique.py Outdated Show resolved Hide resolved
@Gehrkej Gehrkej mentioned this pull request Aug 4, 2024
Closed
2 tasks
FrankreedX and others added 6 commits August 4, 2024 12:49
@FrankreedX
Merge branch 'frankreed/foreignManagement1_blacklist_hook' into frank…
5e1dc1b 
…reed/foreignManagement2_blacklist_tab
@FrankreedX
Merge branch 'frankreed/foreignManagement1_blacklist_hook' into frank…
b3481a3 
…reed/foreignManagement2_blacklist_tab
@FrankreedX @Gehrkej
changed console log wording in removeBlacklist
1ae93ef 
Co-authored-by: Jake Gehrke <91503842+Gehrkej@users.noreply.github.com>
@FrankreedX
removed copied over comment
f869cfb
@FrankreedX
Merge remote-tracking branch 'origin/frankreed/foreignManagement2_bla…
30081f4 
…cklist_tab' into frankreed/foreignManagement2_blacklist_tab
@FrankreedX
Merge branch 'frankreed/foreignManagement1_blacklist_hook' into frank…
a066201 
…reed/foreignManagement2_blacklist_tab
@Gehrkej Gehrkej mentioned this pull request Aug 4, 2024
Merged
@FrankreedX FrankreedX requested a review from Gehrkej August 7, 2024 01:25
@FrankreedX FrankreedX merged commit d6aaba8 into frankreed/foreignManagement1_blacklist_hook Aug 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gehrkej Gehrkej Awaiting requested review from Gehrkej

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FrankreedX @Gehrkej