Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved keyboard avoiding in input.js #327

Merged
merged 2 commits into from
Aug 20, 2024
Merged

Improved keyboard avoiding in input.js #327

merged 2 commits into from
Aug 20, 2024

Conversation

FrankreedX
Copy link
Contributor

No description provided.

solderq35
solderq35 approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@solderq35 solderq35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it works. On the Drill Input screen, I was able to scroll the screen while the keyboard was open.

image

@solderq35
Copy link
Contributor

I did a lot of "Panned by: 0" log messages (seems to be triggered by typing into drill input field). Might want to look into hiding these.

image

@FrankreedX
Copy link
Contributor Author

This seems to be Android specific and if I have to guess it's because the new keyboard avoiding library has the print for Android on by accident

Base automatically changed from frankreed/fix_input_close_dialog to main August 20, 2024 07:40
@FrankreedX FrankreedX merged commit d65f72c into main Aug 20, 2024
1 check passed
@FrankreedX FrankreedX deleted the frankreed/improved_keyboard_avoiding_input branch August 20, 2024 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@solderq35 solderq35 solderq35 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FrankreedX @solderq35