Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Don't Merge Until Build] Update - Commented fill all shots button #335

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Gehrkej
Copy link
Contributor

@Gehrkej Gehrkej commented Aug 21, 2024

Description:

This PR simply comments out the "fill all shots" Text in the input screen so it is ready to go when we deploy the application.

I have commented it out instead of deleting it so it is still available when developing

closes #329

Screenshot:

image

Copy link
Contributor

@FrankreedX FrankreedX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be its own PR that preps for posting to the app store, like changing the sign up email requirement and maybe other stuff

@Gehrkej
Copy link
Contributor Author

Gehrkej commented Aug 23, 2024

We can add onto it if want, I just wanted to have something locked and loaded so it was ready to go

@FrankreedX
Copy link
Contributor

If so, currently the restriction on email being verified and from oregonstate is disabled by a TESTING constant being set to true. This PR should set that to false. I'll leave it to you so you know where this constant is

@Gehrkej
Copy link
Contributor Author

Gehrkej commented Aug 24, 2024

Found it and set it to false

@Gehrkej Gehrkej changed the title Update - Commented fill all shots button [Don't Merge Until Build] Update - Commented fill all shots button Aug 24, 2024
@FrankreedX
Copy link
Contributor

Hmm, now that I look at it, it would be better if the "fill all shots" button depend on the "TESTING" constant. And prob any other testing related stuff

@solderq35
Copy link
Contributor

Hmm, now that I look at it, it would be better if the "fill all shots" button depend on the "TESTING" constant. And prob any other testing related stuff

idk if people still use it, but the test user login could probably also be modified to use TESTING constant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove "Fill All Shots" in input
3 participants