Update - minor foreign management UI updates #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrankreedX
requested changes
Aug 23, 2024
There was a problem hiding this comment.
Can you place the empty screen messages in the middle of the screen?
Make the empty message more informative (for the blacklist screen, maybe add how the coach can blacklist a player?). This may require its own PR if you feel like we should change a lot of empty screens to be more informative. If so just create an issue and I can pair with you
|
We could add more details to other screens if needed but I think it was important to add something to these blank screens |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
A simple PR for some UI updates for the Foreign Requests segment.
Screenshots: