Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

calibrated Moving Avg Line #339

Merged
merged 1 commit into from
Aug 29, 2024
Merged

calibrated Moving Avg Line #339

merged 1 commit into from
Aug 29, 2024

Conversation

FrankreedX
Copy link
Contributor

closes #261

solderq35
solderq35 approved these changes Aug 25, 2024
View reviewed changes
Copy link
Contributor

@solderq35 solderq35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested "some positive some negative", "all negative", "all positive" scenarios for first moving average interval.

image
image
image

@FrankreedX FrankreedX merged commit 77e47e0 into main Aug 29, 2024
1 check passed
@FrankreedX FrankreedX deleted the frankreed/fix_misaligned_MA_line branch August 29, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@solderq35 solderq35 solderq35 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Moving avg line is not straight on 0 when there's a negative result
2 participants
@FrankreedX @solderq35