Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt upload to firebase #91

Merged
merged 5 commits into from
Apr 4, 2024
Merged

Attempt upload to firebase #91

merged 5 commits into from
Apr 4, 2024

Conversation

Gehrkej
Copy link
Contributor

@Gehrkej Gehrkej commented Apr 2, 2024

Issue

The current implementation was not uploading the results from an attempt to the database. This would mean after each attempt, all the attempt data was lost.
Related Issue: #89

Changes

Created a function that will does the following:

  • Takes in outputData
  • Creates a new document in the "attempts" collection
  • Appends the ID of the the new document with outputData which creates uploadData
  • Updates the new document with uploadData

Other Notes

  • Currently there is a log message for the new document ID which can be used to validate an attempt has been uploaded through finding it on the firebase console

Copy link
Contributor

@FrankreedX FrankreedX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found the reason for the outputData thing. Check the "createOutputData" function in input.js. You're returning
return {
outputData,
};
instead of
return outputData

@FrankreedX FrankreedX self-requested a review April 4, 2024 17:51
Copy link
Contributor

@FrankreedX FrankreedX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works

@Gehrkej Gehrkej merged commit 6d663c2 into layout Apr 4, 2024
1 check passed
@Gehrkej Gehrkej deleted the Gehrkej/submission-upload branch April 4, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants