Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frankreed/Leaderboard precalculations now stored on Firebase! #92

Merged
merged 4 commits into from
Apr 4, 2024

Conversation

FrankreedX
Copy link
Contributor

No description provided.

@FrankreedX FrankreedX changed the base branch from main to layout April 3, 2024 18:16
Copy link
Contributor

@artkolpakov artkolpakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great work!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While it isn't directly correlated to this PR, currently there is no way to go back when looking at drill results. I think a simple solution would be adding appbar with a back chevron

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm thinking of tackling this in a different PR because I want to merge the 2 result screen into 1 file.

Copy link
Contributor

@Gehrkej Gehrkej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only have the one comment, the rest seems to be working well. Good job Frank! We will probably have to go over how you wanted to update the best_attempt table at some point but we will figure it out!

@FrankreedX FrankreedX force-pushed the frankreed/store_leaderboard_calculations branch from 65d870c to 28a5aff Compare April 4, 2024 20:40
Copy link
Contributor

@solderq35 solderq35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can probably be moved into another PR / put in github issues, but should we show a fixed amount of decimals on the frontend (add trailing zeros as padding where needed?)

image

Copy link
Contributor

@solderq35 solderq35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the minor issue in the last comment I think it looks good. Tested regular user and test user, definitely seems to be loading the leaderboard much faster and less reads shown on firestore console as well.

@FrankreedX
Copy link
Contributor Author

This can probably be moved into another PR / put in github issues, but should we show a fixed amount of decimals on the frontend (add trailing zeros as padding where needed?)

image

Screenshot 2024-04-04 at 4 19 12 PM Like this?

@FrankreedX FrankreedX merged commit e5f5f0a into layout Apr 4, 2024
1 check passed
@FrankreedX FrankreedX deleted the frankreed/store_leaderboard_calculations branch April 4, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants