-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Frankreed/Leaderboard precalculations now stored on Firebase! #92
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While it isn't directly correlated to this PR, currently there is no way to go back when looking at drill results. I think a simple solution would be adding appbar with a back chevron
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm thinking of tackling this in a different PR because I want to merge the 2 result screen into 1 file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only have the one comment, the rest seems to be working well. Good job Frank! We will probably have to go over how you wanted to update the best_attempt table at some point but we will figure it out!
65d870c
to
28a5aff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the minor issue in the last comment I think it looks good. Tested regular user and test user, definitely seems to be loading the leaderboard much faster and less reads shown on firestore console as well.
No description provided.